inconsistent queries for JpaSagaStore

Imported from Google Groups
#1

Hi all,

I noticed the LOAD_SAGA_QUERY and UPDATE_SAGA_QUERY statements defined in JpaSagaStore use sagaId and sagaType in the where-clause. The DELETE_SAGA_QUERY statement on the other hand only uses sagaId. Is there any particular reason why?

Thanks,
Benoît

#2

Hi Benoit,

I think this is a bit of legacy that is still around since Axon 2. Saga instances are uniquely identified by their sagaId, so adding the extra sagaType isn’t necessary (anymore).

Cheers,

Allard

#3

Thanks Allard,

I’ll check the JDBC version as well and provide a PR.

Cheers,
Benoît